-
Notifications
You must be signed in to change notification settings - Fork 78
mics(FR-1833): Modified BAIAdminResourceGroupSelect to use scaling group name as value #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 63.5% | 254/400 |
| 🔴 | Branches | 42.3% | 151/357 |
| 🔴 | Functions | 50% | 46/92 |
| 🟡 | Lines | 65.16% | 230/353 |
Test suite run success
186 tests passing in 9 suites.
Report generated by 🧪jest coverage report action from 34ee029
…oup name as value
84bf228 to
34ee029
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modifies the BAIAdminResourceGroupSelect component to use the scaling group's name instead of id as the value for select options, aligning with the fact that scaling groups use their name as the primary key in the database.
Key Changes
- Changed the
valuefield fromitem.node.idtoitem.node.namein the select options mapping - Added an explanatory comment noting that scaling groups use name as their primary key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


resolves #4900 (FR-1833)
Changed the value of resource group select options from
idtonamein theBAIAdminResourceGroupSelectcomponent. This ensures that the resource group name is used as the value instead of its ID when selecting resource groups in the admin interface.Checklist: (if applicable)