Skip to content

Conversation

@nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Jan 2, 2026

resolves #4900 (FR-1833)

Changed the value of resource group select options from id to name in the BAIAdminResourceGroupSelect component. This ensures that the resource group name is used as the value instead of its ID when selecting resource groups in the admin interface.

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee changed the title mics(FR-1830): Modified BAIAdminResourceGroupSelect to use scaling group name as value mics(FR-1833): Modified BAIAdminResourceGroupSelect to use scaling group name as value Jan 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Coverage report for ./packages/backend.ai-ui

St.
Category Percentage Covered / Total
🟡 Statements 63.5% 254/400
🔴 Branches 42.3% 151/357
🔴 Functions 50% 46/92
🟡 Lines 65.16% 230/353

Test suite run success

186 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 34ee029

@nowgnuesLee nowgnuesLee marked this pull request as ready for review January 2, 2026 08:38
@nowgnuesLee nowgnuesLee requested review from agatha197, Copilot, ironAiken2 and yomybaby and removed request for Copilot January 2, 2026 08:38
Copilot AI review requested due to automatic review settings January 5, 2026 06:43
@nowgnuesLee nowgnuesLee force-pushed the mics/modify-to-use-scaling-group-name-as-value branch from 84bf228 to 34ee029 Compare January 5, 2026 06:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the BAIAdminResourceGroupSelect component to use the scaling group's name instead of id as the value for select options, aligning with the fact that scaling groups use their name as the primary key in the database.

Key Changes

  • Changed the value field from item.node.id to item.node.name in the select options mapping
  • Added an explanatory comment noting that scaling groups use name as their primary key

Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I test it? There's only storybook where uses BAIAdminResourceGroupSelect in webui. But it occurs errors. Please update PR description details.
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add name fetching logic to BAIAdminResourceGroupSelect to display labels correctly

3 participants