Skip to content

Conversation

@minikube-bot
Copy link
Collaborator

The nerdctl project released a new version

This PR was auto-generated by make update-nerdctl-version using update-nerdctl-version.yml CI Workflow.

@minikube-bot
Copy link
Collaborator Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nirs December 10, 2025 18:49
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2025
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, building a new ISO failed for Commit 0a27ed4
See the logs at:
https://storage.cloud.google.com/minikube-builds/logs/22099/0a27ed4/iso_build.txt

@nirs
Copy link
Contributor

nirs commented Dec 10, 2025

@medyagh - the iso build failed with:

go build -trimpath "-buildmode=pie"  -tags "seccomp" -ldflags "-X main.gitCommit=8bd78a9977e604c4d5f67a7415d7b8b8c109cdc4  " -o runc .
# github.com/opencontainers/runc/libcontainer/configs
libcontainer/configs/config.go:332:25: undefined: strings.SplitSeq

I think the issue is using old Go version for the iso. strings.SplitSeq was added in go 1.24.0 but we still
use go 1.23.4 for the iso:

>>> host-go-bin  Downloading
wget -nd -t 3 --connect-timeout=10 -O '/home/jenkins/workspace/iso-pr-build/out/buildroot/output-aarch64/build/.go1.23.4.linux-amd64.tar.gz.Ejs9Xp/output' 'https://go.dev/dl/go1.23.4.linux-amd64.tar.gz' 
--2025-12-10 20:32:30--  https://go.dev/dl/go1.23.4.linux-amd64.tar.gz

So before we can update nerdctl and containerd we need to update go.

PR updating go to 1.25.5: #22101

@nirs
Copy link
Contributor

nirs commented Dec 11, 2025

We need to trigger again when #22101 is merged.

/close

@k8s-ci-robot
Copy link
Contributor

@nirs: Closed this PR.

In response to this:

We need to trigger again when #22101 is merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants