fix: check the caData field too #386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Zhang <[email protected]>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jwtty
reviewed
Dec 19, 2025
| } else { | ||
| // throw an alert | ||
| _ = controller.NewUnexpectedBehaviorError(fmt.Errorf("cluster certificate authority data not found in member cluster %s status", mc.Name)) | ||
| cp.Status.AccessProviders[0].Cluster.InsecureSkipTLSVerify = true |
Collaborator
There was a problem hiding this comment.
Why do we want to remove this line?
Contributor
Author
There was a problem hiding this comment.
oh, actually there was a comment from @michaelawyu on the previous PR. It's better to play safe and not assume that we should use insecure mode since this is unexpected.
jwtty
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fix the issue that clusterProfile's CAData is not populated. No test can be easily added as the member agent use incluster usually which does not have CAData populated. This only happens if somehow a kubeConfig env is set for a controller.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer