fix: add CEL to block user from changing External rollout strategy type to others #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britaniar
changed the title
britaniar
changed the title
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
britaniar
force-pushed
the
strategyPlacementCRDChange
branch
from
1d7476c to
f06f3ef
Compare
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
Signed-off-by: Britania Rodriguez Reyes <[email protected]>
ryanzhang-oss
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Made placement CRD changes to block changing from external to other types of strategys..
Add API validation test
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
This is related to resource snapshot changes where an external strategy type CRP will not create a resourceSnapshot. The update run controller makes the snapshot vs the placement controller. Otherwise, race conditions could occur when the user updates the spec and two controllers handle the resourceSnapshots concurrently.