-
Notifications
You must be signed in to change notification settings - Fork 173
Run TestInt_PrivateGitRepository from temp directory #3214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run TestInt_PrivateGitRepository from temp directory #3214
Conversation
|
Hi @intojhanurag. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3214 +/- ##
=======================================
Coverage 51.81% 51.81%
=======================================
Files 162 162
Lines 19131 19131
=======================================
Hits 9912 9912
Misses 8241 8241
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @lkingland , Is this good to go ? Can you review , if you have a moment. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: intojhanurag, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the fix! Looks good; just need to resolve the merge conflict to use the new test's name (all Integration tests now need to begin with TestInt_) and should be ready to merge |
9481bdb to
8c24d5d
Compare
|
Hey @gauron99 , It is ready now . pLease take a look 😀 |
gauron99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
fix: #3196
This PR updates TestInt_PrivateGitRepository to run from a temporary working
directory instead of directly using pkg/builders/testdata. The previous behavior
created a .s2i directory inside testdata during execution, causing unwanted
repository changes.
The test now copies the function source into a temporary directory before
running, consistent with other integration tests.