Skip to content

Conversation

@intojhanurag
Copy link
Member

fix: #3196

This PR updates TestInt_PrivateGitRepository to run from a temporary working
directory instead of directly using pkg/builders/testdata. The previous behavior
created a .s2i directory inside testdata during execution, causing unwanted
repository changes.

The test now copies the function source into a temporary directory before
running, consistent with other integration tests.

@knative-prow
Copy link

knative-prow bot commented Nov 19, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.81%. Comparing base (b039190) to head (8c24d5d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3214   +/-   ##
=======================================
  Coverage   51.81%   51.81%           
=======================================
  Files         162      162           
  Lines       19131    19131           
=======================================
  Hits         9912     9912           
  Misses       8241     8241           
  Partials      978      978           
Flag Coverage Δ
integration 17.88% <ø> (ø)
unit macos-14 44.37% <ø> (ø)
unit macos-latest 44.37% <ø> (ø)
unit ubuntu-24.04-arm 44.56% <ø> (ø)
unit ubuntu-latest 45.31% <ø> (ø)
unit windows-latest 44.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@intojhanurag
Copy link
Member Author

Hey @lkingland , Is this good to go ? Can you review , if you have a moment.

@lkingland lkingland added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: intojhanurag, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@lkingland
Copy link
Member

lkingland commented Nov 21, 2025

Thanks for the fix!

Looks good; just need to resolve the merge conflict to use the new test's name (all Integration tests now need to begin with TestInt_) and should be ready to merge

@intojhanurag intojhanurag force-pushed the fix/private-git-repo-tempdir branch from 9481bdb to 8c24d5d Compare November 21, 2025 07:26
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2025
@intojhanurag
Copy link
Member Author

Hey @gauron99 , It is ready now . pLease take a look 😀

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@knative-prow knative-prow bot merged commit 4611128 into knative:main Nov 21, 2025
65 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Execute TestInt_PrivateGitRepository from temp directory

4 participants