Add support for repeated get params in aiohttp #345
Conversation
dedsm
force-pushed
the
feature/aiohttp_repeated_get_params
branch
from
08361bc to
17d95b1
Compare
|
@dedsm thanks for your PR 🙂 can you update your branch? this way we can follow the review/merge of this PR |
tox.ini
Outdated
There was a problem hiding this comment.
IMO this requirement is aiohttp only, so maybe it would better to tweak tox.ini by changing this line (as below) and moving it to the end of this section.
aiohttp: multidict
dedsm
force-pushed
the
feature/aiohttp_repeated_get_params
branch
from
17d95b1 to
f09f709
Compare
|
@lamenezes I guess you were referring to me to update the PR and not @carsonyl I updated the PR and added the proposed changes. I played around with dropping the fixed "<3" requirement for aiohttp in the tox.ini but I think it won't play nice with python < 3.6 |
Oops. I'm really sorry about that 😅 I should pay better attention when replying to multiple PRs |
tests/integration/test_aiohttp.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| import multidict | |||
There was a problem hiding this comment.
I think here we'll have to use pytest.importorskip('multidict') to avoid all those CI builds failures. We had to do th same with aiohttp (on line 3)
|
@dedsm can you rebase your branch on master in order to resolve the conflicts ? |
dedsm
force-pushed
the
feature/aiohttp_repeated_get_params
branch
2 times, most recently
from
743ab52 to
6865dbe
Compare
|
@arthurHamon2 I rebased it, hopefully it still stands |
dedsm
force-pushed
the
feature/aiohttp_repeated_get_params
branch
from
6865dbe to
f87b075
Compare
dedsm
force-pushed
the
feature/aiohttp_repeated_get_params
branch
from
f87b075 to
28416d6
Compare
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c to
34d5384
Compare
4 participants
aiohttp supports receiving list of pairs or multidict in case you want to send repeated ids, this PR adds support for this.