Mention comments and whitespace in format accessors
#124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kdl-org/kdl#68 (comment), I totally missed that it was already possible to access comments, even after looking through the docs.
I think I searched for "comments" on the docs, without looking deeply enough into the
Formattypes andformataccessors realizing that the data was already there.Added a name drop of comments and whitespace on all of the
formataccessors, to make it easier to find for other folks that aren't as familiar with the API, like I wasn't.If there's a better way you can think of highlighting this, happy to do so.
Thanks again for helping me realize it was already supported :)