perf(rss/atom/json): Use .forEach() instead of .map() when resulting array is unused
#234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing array is unused Existing functionality is not changed, and tests still pass. This improves performance by reducing unnecessary work. Fix jpmonette#233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing functionality is not changed, and tests still pass.
This improves (marginally) performance by reducing unnecessary work. More importantly though, this change makes the code slightly easier to read and maintain, by explicitly using
.map()only when.forEach()is not enough. This makes the intention clearer.Fix #233