Re-apply fix for Sparkle dialog buttons unresponsive #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RunLoopLocalEventMonitor` seems to prevent certain buttons from receiving events in macOS 26 Developer Beta 1. This might be a bug in the beta, or `RunLoopLocalEventMonitor` itself. For now, let's just move to a better mouse check implementation that doesn't use continuous event monitoring. Note the `FIXME` (line 1057). The previous implementation had this problem too, but it was never documented.
zhaopengme
added a commit
to zhaopengme/IcePlus
that referenced
this pull request
Dec 25, 2025
…ordanbaird#820 - PR jordanbaird#804: Fix memory leak - Remove expired CGImages from cache Fixes issue where CGImage cache grows unbounded on long-running systems - PR jordanbaird#803: Fix menu bar clipping on secondary monitor Resolves overlay panel incorrectly showing on external displays - PR jordanbaird#820: Fix Sparkle dialog buttons unresponsive Re-applies fix for update dialog being unclickable (macOS 26 compatibility) Replaces RunLoopLocalEventMonitor with better mouse state checking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681
This PR re-applies a fix that was accidentally reverted. I tested it locally and the Sparkle update window is responsive again.
In case I'm wrong with the accidental revert please let me know.
Same if there is something specific you want me to test.
Timeline
Changes
Cherry-picked commit 075581c:
RunLoopLocalEventMonitorfrom continuous mouse trackingMouseEventshelper for checking mouse stateMouseCursor.swift→MouseHelpers.swift