Refactoring #325
Refactoring #325
Conversation
* chore: enable more linters and fix linter issues * ci: enable linter checks on all branches and disable recurring checks recurring linter checks don't make that much sense. The code & linter checks should not change on their own over night ;) * chore: update packages * Revert "chore: update packages" This reverts commit 30250bf. * chore: manually upgrade some packages
|
How can we help you get this merged? Are there specific areas that need/could use review? Or is it simply an question of time? (totally valid, no worries) |
|
@hellerbarde I'm on it now! Thanks for the bump, it's been mainly a time issue as I have multiple projects on my hands and as the refactoring wasn't super high on the priority list, it just simply got forgotten. It's important to get in however, as not merging it is effectively blocking fixes and features in order to not to create a jungle of merge conflicts. |
|
is there any method to sponsor your work? If we raised some funds would it help you complete this PR and move things forward? |
|
@joohoi is there anywhere in particular you would like me to focus some testing attention? |
* Increase code coverage in acmedns * More testing of ReadConfig() and its fallback mechanism * Found that if someone put a '"' double quote into the filename that we configure zap to log to, it would cause the the JSON created to be invalid. I have replaced the JSON string with proper config * Better handling of config options for api.TLS - we now error on an invalid value instead of silently failing. added a basic test for api.setupTLS() (to increase test coverage) * testing nameserver isOwnChallenge and isAuthoritative methods * add a unit test for nameserver answerOwnChallenge * fix linting errors * bump go and golangci-lint versions in github actions * Update golangci-lint.yml Bumping github-actions workflow versions to accommodate some changes in upstream golanci-lint * Bump Golang version to 1.23 (currently the oldest supported version) Bump golanglint-ci to 2.0.2 and migrate the config file. This should resolve the math/rand/v2 issue * bump golanglint-ci action version * Fixing up new golanglint-ci warnings and errors --------- Co-authored-by: Joona Hoikkala <[email protected]>
|
@bluntelk Thanks for your work on the tests! Highly appreciated. I'm currently doing the required modifications in order to transfer the repository over to the acme-dns organization from my personal namespace. |
Huge refactoring PR to get acme-dns to a more maintainable state. Some new improvements done at the same time.