Introduce a version of the circular import test #2292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
force-pushed
the
circular-import-test
branch
2 times, most recently
from
b44f0c2 to
346dc75
Compare
This is ported from the version in aiohttp with minimal changes. Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
sirosen
force-pushed
the
circular-import-test
branch
from
346dc75 to
449123a
Compare
webknjaz
approved these changes
Nov 29, 2025
webknjaz
reviewed
Nov 29, 2025
Member
|
@sirosen we should probably manually watch the patch coverage until we can enforce it for real, right? |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Member
Author
Yeah, I've been wondering about that. I got sidetracked when trying to put together a coverage plugin config which would work for us. In the meantime, it would be good to avoid these spurious failures. |
webknjaz
reviewed
Nov 29, 2025
|
|
||
| def _allowed_deprecation_warning_filters() -> list[str]: | ||
| """ | ||
| Yield filters which allow for deprecation warnings based on the current |
Member
There was a problem hiding this comment.
(this would've actually been more elegant as a generator FWIW)
Member
Author
There was a problem hiding this comment.
Oh, haha, clearly from the doctoring I intended to write it as a generator! It's fine, but I might come back and fix it sometime...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures that we don't have circular imports allowed in the project.
(ported from #2286 )
Contributor checklist
changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".Maintainer checklist
bot:chronographer:skiplabel.