Skip to content

Conversation

@pranjalg1331
Copy link

@pranjalg1331 pranjalg1331 commented Oct 18, 2025

Which problem is this PR solving?

Resolves #7594

Description of the changes

I added support for filtering the traces based on attributes passed.

How was this change tested?

  • I checked the response I got from the GET request and it showed the correct filtered data.
    http://localhost:16686/api/v3/traces?query.num_traces=1&query.service_name=frontend&query.start_time_max=2025-10-19T15%3A54%3A58.373570048Z&query.start_time_min=2025-10-16T14%3A54%3A59.373570048Z&query.attributes={%22driver%22%3A%22T704822C%22}

Checklist

Signed-off-by: pranjalg1331 <[email protected]>
Signed-off-by: pranjalg1331 <[email protected]>
@pranjalg1331
Copy link
Author

pranjalg1331 commented Oct 18, 2025

I also noticed that attributes is not mentioned in Swagger docs.
Also, when querying the traces, the limit was passed as "num_traces" instead of search_depth
@yurishkuro Should I raise a pr adding these changes manually in jaeger-idl?

@pranjalg1331 pranjalg1331 marked this pull request as ready for review October 19, 2025 12:23
@pranjalg1331 pranjalg1331 requested a review from a team as a code owner October 19, 2025 12:23
@pranjalg1331 pranjalg1331 requested a review from jkowall October 19, 2025 12:23
@dosubot dosubot bot added the enhancement label Oct 19, 2025
@yurishkuro
Copy link
Member

Should I raise a pr adding these changes manually in jaeger-idl?

yes otherwise this change violates the schema

@pranjalg1331
Copy link
Author

I have a created a pr for docs update.
@yurishkuro please review 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support parameters for attributes and limit in api/v3/traces endpoint

2 participants