fix(graph): properly setup default scale #2201
Open
+43
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. scale should affect the whole graph, not labels. 2. scale should affect even when zoom disabled.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The
scaleinGraph.tsxis expected to scale the whole graph as default, but it only scales labels.Solution:
This change would make default labels "a little" big (about x1.1), due to the previous bug, but I think it's acceptable. If we really want to customize the label scale, I kept a line there.