-
Notifications
You must be signed in to change notification settings - Fork 314
update dependencies #3307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update dependencies #3307
Conversation
2ba129c to
fc679ba
Compare
fc679ba to
74bab42
Compare
|
/retest |
|
Given how likely this is to break things which will halt merges into the master branch once this merges and becomes effective, we will need to make sure we have someone ready to pounce on issues that come up and fix them. |
|
@jacob-delgado : what would be the right time to merge this one? Hope we will have time to work on any regressions once merged |
|
@kfaseela asap honestly. We just need someone to be able to commit to fixing things as broken. But we can do sanity checks once it is merged with the image built and PR pushed to common-files. I'd recommend we do that and then put a DNM/hold on it there. Then we can start testing |
|
@jacob-delgado: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
includes helm3 v4.0.0
fixes istio/istio#58302