Skip to content

Conversation

@jacob-delgado
Copy link
Contributor

@jacob-delgado jacob-delgado commented Nov 17, 2025

includes helm3 v4.0.0

fixes istio/istio#58302

@jacob-delgado jacob-delgado requested a review from a team as a code owner November 17, 2025 17:35
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2025
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 22, 2025
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2025
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 25, 2025
@jacob-delgado
Copy link
Contributor Author

/retest

@jacob-delgado jacob-delgado requested a review from dhawton December 1, 2025 18:13
@dhawton
Copy link
Member

dhawton commented Dec 2, 2025

Given how likely this is to break things which will halt merges into the master branch once this merges and becomes effective, we will need to make sure we have someone ready to pounce on issues that come up and fix them.

@kfaseela
Copy link
Member

kfaseela commented Dec 9, 2025

@jacob-delgado : what would be the right time to merge this one? Hope we will have time to work on any regressions once merged

@jacob-delgado
Copy link
Contributor Author

@kfaseela asap honestly. We just need someone to be able to commit to fixing things as broken. But we can do sanity checks once it is merged with the image built and PR pushed to common-files.

I'd recommend we do that and then put a DNM/hold on it there. Then we can start testing

@istio-testing
Copy link
Contributor

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
containers-test_tools 4387ed4 link true /test containers-test
containers-test-arm64_tools 4387ed4 link true /test containers-test-arm64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm v4 support

4 participants