Skip to content

security: Fix js/file-system-race (CWE-367) security issue #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabasoad wants to merge 2 commits into from
Closed

security: Fix js/file-system-race (CWE-367) security issue #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f2364f
fix: security issues
fabasoad Sep 22, 2025
ade5a30
chore: cleanup
fabasoad Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,18 @@ export const filesFilter = (opt: TarOptions, files: string[]) => {
const listFileSync = (opt: TarOptionsSyncFile) => {
const p = new Parser(opt)
const file = opt.file
let fd
let fd: number | undefined
try {
const stat = fs.statSync(file)
const readSize = opt.maxReadSize || 16 * 1024 * 1024
fd = fs.openSync(file, 'r')
const stat: fs.Stats = fs.fstatSync(fd)
const readSize: number = opt.maxReadSize || 16 * 1024 * 1024
if (stat.size < readSize) {
p.end(fs.readFileSync(file))
const buf = Buffer.allocUnsafe(stat.size)
fs.readSync(fd, buf, 0, stat.size, 0)
p.end(buf)
} else {
let pos = 0
const buf = Buffer.allocUnsafe(readSize)
fd = fs.openSync(file, 'r')
while (pos < stat.size) {
const bytesRead = fs.readSync(fd, buf, 0, readSize, pos)
pos += bytesRead
Expand Down