-
Notifications
You must be signed in to change notification settings - Fork 8
Add canopy cover #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add canopy cover #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- calculate: add using 1 − exp(−k·PAIabove(z)) - process: support with and options - api: export in - tests: add unit tests for canopy cover (expected value, zero PAD, NaNs, monotonic with z) - docs: add canopy cover usage page, link from intro, and update example notebook to compute and plot cover (z=2 m) Signed-off-by: iosefa <[email protected]>
Improved masking by targeting columns with zero returns across all Z levels, ensuring accuracy in handling truly empty columns.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
- Enhance error handling for malformed or missing bounds data. - Support multiple bounds formats, including list/tuple and dictionary. - Update related test cases for better coverage and assertions. - Adjust docstring for clarity and updated argument descriptions.
cankanoa
previously approved these changes
Oct 9, 2025
Collaborator
cankanoa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
- Replace random voxel returns with structured values to avoid flaky test behavior. - Add columns for entropy edge cases: single-bin mass (entropy 0) and uniform distribution (maximal entropy).
cankanoa
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #31
Add canopy cover metric