Bug/pad calculation #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benleamon
previously approved these changes
Jun 10, 2025
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
🚀 New features to boost your workflow:
|
Simplified voxel grid logic and improved robustness for handling spatial data points. Refactored PAD computation to eliminate redundant calculations and ensure better error handling. Enhanced PAI calculation to support height-based slicing with clearer parameterization.
Updated the docstring to use "Args" and "Returns" for better readability and consistency with standard Python practices. The changes streamline parameter and return value descriptions without altering functionality.
Added validation for voxel height and height ranges to ensure inputs are consistent. Updated `calculate_pad` and `calculate_pai` functions to improve error checks and fix nan handling. Refactored tests for increased coverage, addressing edge cases for PAD/PAI computations.
…clarity Revised and standardized docstrings across key functions using the "Args" and "Returns" format for improved readability and consistency. Adjustments include clearer parameter definitions, better exception descriptions, and streamlined documentation for various modules (`filters.py`, `handlers.py`, `process.py`, etc.). Updated README to include documentation editing and publishing instructions, providing contributors with detailed steps for maintaining project docs.
Added a new GitHub Actions workflow to build and deploy project documentation using MkDocs. This includes installing MkDocs and necessary plugins, building the site, and deploying it to GitHub Pages.
Deleted the outdated `working-with-large-point-clouds.ipynb` tutorial from the documentation examples. The notebook content was no longer relevant and duplicated information available in other updated resources.
iosefa
force-pushed
the
bug/pad-calculation
branch
from
8c87585 to
80b10b8
Compare
cankanoa
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the horizontal grid from 5 m to 25–30 m used to inflate mean PAD / PAI by > 200 %.
Root causes fixed here:
Main code changes
calculate.pyassign_voxels• Y bins generated in descending order → final array still north-up
calculate_padcumsumalgorithm• option
drop_ground=True(default)• removed old “reverse stack” logic
calculate_paivoxel_height(dz) and integrates using physical heights rather than raw indicesBehavioural impact