[v12] feat(ui-pill): Pill rework #2293
Open
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-nandor
force-pushed
the
INSTUI-4800_pill_rework
branch
from
1abeb41 to
a02b805
Compare
|
git-nandor
force-pushed
the
INSTUI-4800_pill_rework
branch
from
a02b805 to
ae51213
Compare
matyasf
requested changes
Dec 11, 2025
Collaborator
matyasf
left a comment
matyasf
left a comment
There was a problem hiding this comment.
The example in the docs page is weird, it shows all the themes. Please rewrite it, so it only shows the current theme.
| borderWidth: componentTheme.borderWidth, | ||
| borderStyle: componentTheme.borderStyle, | ||
| borderRadius: componentTheme.borderRadius, | ||
| fontFamily: componentTheme.fontFamily, |
Collaborator
There was a problem hiding this comment.
lineHeight style token is not used, it should be either deleted or used
Collaborator
There was a problem hiding this comment.
I'm not sure why it has been added but its not essential. @hajnaldo ?
adamlobler
requested changes
Dec 13, 2025
Collaborator
adamlobler
left a comment
adamlobler
left a comment
There was a problem hiding this comment.
We should update the showcase as well. Right now, it’s using the legacy icons, but we should use the new Lucide icons instead.
Also, we should only show the components in one theme, just like the other showcases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4800
Summary
Migrated Pill component from the old theming system.
Test plan
On the documentation page, verify that everything displays and works correctly.
Co-Authored-By: 🤖 Claude