Mesh preparedness fixes #32111
Mesh preparedness fixes #32111
Conversation
Upcoming libMesh versions will assert that we're not trying to access certain types of cached data (like mesh dimensions) that isn't marked as already prepared. Also, in general it isn't safe to be using cached data that isn't marked as prepared. Refs idaholab#15945
This fixes libMesh/libmesh#3759 regressions in the GridPartitioner mesh splitting tests for me. When we recognize that an unpartitioned mesh is unprepared (which the libMesh PR now does), and that prompts MOOSE to call prepare_for_use(), we'd better still have partitioning disabled unless we want to see some partitioning.
libMesh is going to start screaming if it's asked to report certain types of cached data on unprepared meshes.
|
Job Documentation, step Docs: sync website on f6f24a5 wanted to post the following: View the site here This comment will be updated on new commits. |
Co-authored-by: Guillaume Giudicelli <[email protected]>
|
Job Precheck, step Clang format on 47b5a99 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
|
Job Test, step Results summary on f6f24a5 wanted to post the following: Framework test summaryCompared against cc8efb1 in job civet.inl.gov/job/3456352. No change Modules test summaryCompared against cc8efb1 in job civet.inl.gov/job/3456352. No added testsRun time changes
|
|
Job Coverage, step Generate coverage on f6f24a5 wanted to post the following: Framework coverage
Modules coveragePeridynamics
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
4 participants
Reason
Some of the additional error checking in libMesh/libmesh#3759 has exposed issues in MOOSE code; those need to be fixed before we can be confident the libMesh PR is ready to merge.
Design
is_prepared()first and prepare if necessary.Impact
In theory no impact. When we merge the next libMesh submodule there may be other similar errors exposed downstream.