Support openapi 'servers' #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes a test with the previous spec file (https://api.apis.guru/v2/specs/medium.com/1.0.0/swagger.json) that is no longer available. Signed-off-by: Arturo Volpe <[email protected]>
Signed-off-by: Arturo Volpe <[email protected]>
In openapi 3 the 'schemes' and 'basePath' were replaced with a single property called 'servers', in this property we introduce the available servers with the full path, for example: ```yaml servers: - url: https://statsapi.web.nhl.com/api/v1 ``` With this change, a flag is added in the parsing of the context `is_open_api` that can be used to check for the new properties available in open api 3. fixes httpie#197 Signed-off-by: Arturo Volpe <[email protected]>
|
Any chance to get it merged? OpenAPI ecosystem is not sleeping and v3 is used all over the place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In openapi 3 the 'schemes' and 'basePath' were replaced with a single
property called 'servers', in this property we introduce the available
servers with the full path, for example:
With this change, a flag is added in the parsing of the context
is_open_apithat can be used to check for the new properties availablein open api 3.
fixes #197
This PR also fixes the test
test_spec_from_http_onlythat relied on an old spec that is no longer available.