Skip to content

Conversation

@Vaskivskyi
Copy link
Contributor

Proposed change

Bump asusrouter dependency for asuswrt integration. The update contains a bug fix for the issue with some recent FW versions, which prevented proper parsing of the client list.

No other changes related to the integration. No breaking changes.

Links: Release notes

Currently, the integration will show 0 clients and an error in the log
image

With this updated dependency:
image

I would appreciate tagging this PR for the next minor release, so that affected users can get the fix as fast as possible.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Dec 7, 2025

Hey there @kennedyshead, @ollo69, mind taking a look at this pull request as it has been labeled with an integration (asuswrt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of asuswrt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign asuswrt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the asusrouter dependency from version 1.21.0 to 1.21.1 for the asuswrt integration. The update addresses a bug in client list parsing that affects routers running recent firmware versions, which was causing the integration to display 0 clients and log errors.

Key Changes:

  • Updated asusrouter dependency version from 1.21.0 to 1.21.1 across all requirement files
  • No code changes to the integration itself
  • No breaking changes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
requirements_test_all.txt Updated asusrouter test dependency to version 1.21.1
requirements_all.txt Updated asusrouter production dependency to version 1.21.1
homeassistant/components/asuswrt/manifest.json Updated asusrouter requirement in manifest to version 1.21.1

Review Summary: The changes are clean and consistent. All three files correctly reference the new version 1.21.1, and no references to the old version remain in the codebase. This is a straightforward dependency bump with no code changes, appropriate for a bugfix release.

@MS2620
Copy link

MS2620 commented Dec 7, 2025

The update resolves a client list parsing bug affecting routers running recent firmware versions, which previously caused the integration to display zero clients and generate errors. This is a straightforward but important fix that will benefit all current users experiencing these issues.

@zweckj zweckj added this to the 2025.12.2 milestone Dec 8, 2025
@joostlek joostlek merged commit 5ca6138 into home-assistant:dev Dec 8, 2025
73 checks passed
@Vaskivskyi Vaskivskyi deleted the ar-1.21.1 branch December 8, 2025 16:15
frenck pushed a commit that referenced this pull request Dec 8, 2025
@frenck frenck mentioned this pull request Dec 8, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants