-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Bump asusrouter to 1.21.1 #158192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump asusrouter to 1.21.1 #158192
Conversation
|
Hey there @kennedyshead, @ollo69, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR bumps the asusrouter dependency from version 1.21.0 to 1.21.1 for the asuswrt integration. The update addresses a bug in client list parsing that affects routers running recent firmware versions, which was causing the integration to display 0 clients and log errors.
Key Changes:
- Updated asusrouter dependency version from 1.21.0 to 1.21.1 across all requirement files
- No code changes to the integration itself
- No breaking changes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements_test_all.txt | Updated asusrouter test dependency to version 1.21.1 |
| requirements_all.txt | Updated asusrouter production dependency to version 1.21.1 |
| homeassistant/components/asuswrt/manifest.json | Updated asusrouter requirement in manifest to version 1.21.1 |
Review Summary: The changes are clean and consistent. All three files correctly reference the new version 1.21.1, and no references to the old version remain in the codebase. This is a straightforward dependency bump with no code changes, appropriate for a bugfix release.
|
The update resolves a client list parsing bug affecting routers running recent firmware versions, which previously caused the integration to display zero clients and generate errors. This is a straightforward but important fix that will benefit all current users experiencing these issues. |
Proposed change
Bump asusrouter dependency for asuswrt integration. The update contains a bug fix for the issue with some recent FW versions, which prevented proper parsing of the client list.
No other changes related to the integration. No breaking changes.
Links: Release notes
Currently, the integration will show 0 clients and an error in the log

With this updated dependency:

I would appreciate tagging this PR for the next minor release, so that affected users can get the fix as fast as possible.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: