Skip to content

Conversation

@sesposito
Copy link
Member

@sesposito sesposito commented Nov 21, 2025

Update Satori client functionality.
Improve Apple IAP notification handling.
Configurable socket closure ack wait timeout.

@sesposito sesposito requested a review from zyro November 21, 2025 16:31
@sesposito sesposito force-pushed the spe/add-satori-event-list-fields branch from 84f2d3c to bce33c8 Compare November 24, 2025 17:22
@sesposito sesposito requested a review from Copilot November 25, 2025 12:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends Satori client functionality by adding new filter parameters for live event listing and a new join function. It also includes improvements to Apple IAP notification handling and reduces the socket closure timeout.

  • Add filter parameters (pastRunCount, futureRunCount, startTimeSec, endTimeSec) to Satori live events list API
  • Add new liveEventJoin function to Satori client for both Lua and JavaScript runtimes
  • Fix Apple IAP notification handling to properly decode optional fields and improve logging

Reviewed changes

Copilot reviewed 9 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
server/session_ws.go Reduced socket close wait timeout from 10s to 2s
server/runtime_lua_nakama.go Added liveEventJoin function and new filter parameters to satoriLiveEventsList
server/runtime_javascript_nakama.go Added liveEventJoin function and new filter parameters to satoriLiveEventsList
server/core_subscription.go Fixed Apple IAP notification handling for optional fields and improved logging
internal/satori/satori_time_cache.go Updated cache to support optional filter parameters as generic type
internal/satori/satori_context_cache.go Updated cache to support optional filter parameters and added liveEventFilters struct
internal/satori/satori.go Added validation and implementation for new live event filter parameters and join function
go.mod Added local replacement directive for nakama-common
CHANGELOG.md Documented the changes with merge conflict markers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sesposito sesposito merged commit bf1c211 into master Nov 26, 2025
7 checks passed
@sesposito sesposito deleted the spe/add-satori-event-list-fields branch November 26, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants