-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add new Satori event list API filter params #2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84f2d3c to
bce33c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR extends Satori client functionality by adding new filter parameters for live event listing and a new join function. It also includes improvements to Apple IAP notification handling and reduces the socket closure timeout.
- Add filter parameters (pastRunCount, futureRunCount, startTimeSec, endTimeSec) to Satori live events list API
- Add new liveEventJoin function to Satori client for both Lua and JavaScript runtimes
- Fix Apple IAP notification handling to properly decode optional fields and improve logging
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| server/session_ws.go | Reduced socket close wait timeout from 10s to 2s |
| server/runtime_lua_nakama.go | Added liveEventJoin function and new filter parameters to satoriLiveEventsList |
| server/runtime_javascript_nakama.go | Added liveEventJoin function and new filter parameters to satoriLiveEventsList |
| server/core_subscription.go | Fixed Apple IAP notification handling for optional fields and improved logging |
| internal/satori/satori_time_cache.go | Updated cache to support optional filter parameters as generic type |
| internal/satori/satori_context_cache.go | Updated cache to support optional filter parameters and added liveEventFilters struct |
| internal/satori/satori.go | Added validation and implementation for new live event filter parameters and join function |
| go.mod | Added local replacement directive for nakama-common |
| CHANGELOG.md | Documented the changes with merge conflict markers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update Satori client functionality.
Improve Apple IAP notification handling.
Configurable socket closure ack wait timeout.