fix: allow parsing without timestamp attribute #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monforton
commented
Dec 14, 2024
mbristol580
reviewed
Dec 16, 2024
mbristol580
reviewed
Dec 16, 2024
mbristol580
reviewed
Dec 16, 2024
mbristol580
approved these changes
Dec 17, 2024
Monforton
force-pushed
the
bug/#15-missing-timestamp
branch
from
476c922 to
88eacd6
Compare
eolatham
reviewed
Dec 17, 2024
Collaborator
|
We can't omitt the timestamp. We need to set it as it's used through fern
and in the code
…On Tue, Dec 17, 2024, 1:16 PM Monforton ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On pkg/util/clock.go
<#17 (comment)>
:
I'm sure there is a more minimal way, this is just the standard one I
found. What do you mean by omitting the time?
—
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6K4K55MWEJHAEBCX67SOHT2GBZ7RAVCNFSM6AAAAABTTA53LSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBZHA3DONJVGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.