feat: make cli available as gh action #16
Conversation
also generate basic metrics for consumption
Monforton
force-pushed
the
feature/github-action
branch
2 times, most recently
from
5a4e42c to
abe72ba
Compare
Monforton
force-pushed
the
feature/github-action
branch
from
abe72ba to
3521da4
Compare
mbristol580
requested review from
cbridges1,
eolatham and
mbristol580
and removed request for
eolatham
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| echo "### Overall Statistics" >> $GITHUB_STEP_SUMMARY | ||
| echo "" >> $GITHUB_STEP_SUMMARY | ||
| echo "- **Total Tests:** \`$total\`" >> $GITHUB_STEP_SUMMARY | ||
| echo "- **Pass Rate:** \`$pass_percentage%\`" > $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Using > operator instead of >> will overwrite the entire job summary instead of appending to it, losing previously written content.
|
|
||
| func main() { | ||
| fmt.Print(strings.TrimLeft(banner, "\n")) | ||
| time.Sleep(1 * time.Microsecond) |
There was a problem hiding this comment.
Unexplained sleep added with no clear purpose. The 1 microsecond duration is so small it's functionally insignificant and likely won't have the intended effect.
| Args: cobra.ExactArgs(0), | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| if err := client.SendReports(fernUrl, projectName, filePattern, tags, verbose); err != nil { | ||
| metricsPath := "test/static/fern_test_run_metrics.txt" |
There was a problem hiding this comment.
Hardcoded file path could cause issues in different environments or when the code is run from different directories
| Args: cobra.ExactArgs(0), | ||
| Run: func(cmd *cobra.Command, args []string) { | ||
| if err := client.SendReports(fernUrl, projectName, filePattern, tags, verbose); err != nil { | ||
| metricsPath := "test/static/fern_test_run_metrics.txt" |
There was a problem hiding this comment.
No directory existence check before writing to the metrics file
| Run: func(cmd *cobra.Command, args []string) { | ||
| if err := client.SendReports(fernUrl, projectName, filePattern, tags, verbose); err != nil { | ||
| metricsPath := "test/static/fern_test_run_metrics.txt" | ||
| if err := client.SendReports(fernUrl, projectName, filePattern, tags, verbose, metricsPath); err != nil { |
There was a problem hiding this comment.
New parameter added without making it configurable via CLI flags
| log.Default().Printf("Total tests failed: %d\n", failed) | ||
| log.Default().Printf("Total tests skipped: %d\n", skipped) | ||
|
|
||
| if file, err := os.Create(metricsFilePath); err != nil { |
There was a problem hiding this comment.
File handling doesn't properly check WriteString errors or use defer for closing
| - name: Run Tests | ||
| ... | ||
| - name: Report tests to fern | ||
| uses: guidewire-oss/fern-junit-client@latest |
There was a problem hiding this comment.
Using 'latest' tag for GitHub Actions can lead to unexpected behavior when breaking changes are introduced
| url: 'https://fern.mydomain.com' | ||
| file-pattern: 'tests/*.xml' | ||
| project-name: 'My Service' | ||
| tags: 'cpu,' |
There was a problem hiding this comment.
Trailing comma in tags list looks like a typo and could be confusing to users
| with: | ||
| url: 'https://fern.mydomain.com' | ||
| file-pattern: 'tests/*.xml' | ||
| project-name: 'My Service' |
There was a problem hiding this comment.
Project identification appears inconsistent between CLI and GitHub Action examples
also generate basic metrics for consumption