Add navigation arrows to product carousel. #15025
Open
+89
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
oliverabrahams
force-pushed
the
mob/scrollable-products
branch
from
f20853d to
a064393
Compare
… carousel. and add a section for the navigation button portal to hydrate
oliverabrahams
force-pushed
the
oa/navigation-arrows
branch
from
ae03857 to
1f51155
Compare
| export const ClickForwardTwiceAndBackOnce = { | ||
| play: async ({ canvas, userEvent }) => { | ||
| const user = userEvent.setup({ | ||
| delay: 500, // delay between each interaction |
Contributor
There was a problem hiding this comment.
Just curious why we need this delay when we have one as part of the parameters?
Contributor
Author
There was a problem hiding this comment.
This delay is to leave time for the carousel to move between interactions. I thought that the delay at the top is before the first click so that the navigation buttons have time to find the element in the DOM where they are supposed to be but that may not be needed. I will do some testing to see if it works without.
Contributor
|
Looks good! Have we tested this for accessibility e.g. keyboard navigation etc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a Heading and navigation arrows to the product carousel.
Adds an interaction story to to the carousel storybook.
builds off this PR #14968
Screenshots