fix(oci collector): support registry endpoints with ports #2827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
This change is a minor modification to the minimum registry validation that performs a dns lookup. To my knowledge and testing - it did not previously support registries that had ports included from the
guaccollect registrycommand.My motivation is to enable a number of registry deployment scenarios that may be running on specific ports - particularly in the deployment to a Kubernetes cluster whereby the oci collector can target internal service endpoints.
Fixes #2826
PR Checklist
-sflag togit commit.make generatehas been runmake generatehas been runmake generatehas been runcollectsubprotobuf has been changed,make protohas been run