Skip to content

Conversation

@connor-hanson
Copy link

@connor-hanson connor-hanson commented Jan 18, 2026

This PR contains several updates, each documented by their respective commit

  1. Move commands & dockerfile to root
    • Motivation: Makefiles were distributed and difficult to follow. Convention is for makefiles to live at the project root. Makefile required updates to accommodate local cli building/cleaning with make build && make clean
    • Changes:
    1. Flatten Makefiles to root level
    2. Move Dockerfile out of build/ directory. Existing build directory conflicts with make build, causing it to think the program had already successfully been built, when it wasn't.
    • Testing
    1. make build && make clean create / destroy executable + build directory
    2. make docker-build runs without error
    3. make docker-run runs until auth refused, but runs command correctly (I don't run any servers on docker, so this is expected that auth fails)
docker run -it --rm \
      -v /Users/connorhanson/workspace/rcon-cli/rcon-local.yaml:/rcon.yaml \
      outdead/rcon ./rcon -c /rcon.yaml  
cli: auth: rcon: dial tcp 127.0.0.1:27015: connect: connection refused

  1. Add MacOs homebrew tap
  • Motivation: Homebrew is a standard macos cli installation tool. I'd like to run this command from my cli via homebrew
  • Changes:
    1. Build macos release binaries to dist/
    2. Update docker-release to not publish on each PR
  • Testing: None. Unsure how to test homebrew releases/github workflows. Should be low impact if not working.

  1. Allow escaped command shortcuts to cli executor
  • Motivation: For mod development using rcon, it is useful to be able to rapidly repeat commands previously used. Current implementation does not handle shortcuts such as using command history
  • Changes:
    1. Update from bufio to cli library which escapes these special characters for us
  • Testing: Manual tests, updated unit tests, removed obsolete unit test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant