ci: skip gcs prod tests creating public buckets

[scotthart]

And handle some spanner unimplemented errors.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the continuous integration pipeline by addressing two distinct issues. It prevents GCS integration tests from creating public buckets in production-like environments by conditionally skipping them, and it improves the resilience of Spanner integration tests by allowing them to pass when optimistic locking features are unimplemented, rather than failing. These changes aim to reduce flakiness and improve the reliability of CI builds.

Highlights

• CI Test Skipping: Several Google Cloud Storage (GCS) integration tests and examples that create public buckets are now conditionally skipped in non-emulator environments to prevent unintended public resource creation during CI runs. This addresses a known issue tracked by TODO(#15854).
• Spanner Error Handling: Spanner integration tests have been updated to gracefully handle kUnimplemented errors specifically related to optimistic locking, ensuring tests pass even when this feature is not enabled in the environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables several Google Cloud Storage tests that create public buckets, likely to address a CI issue. The tests are skipped for production runs but remain active for the emulator, which is a reasonable approach for a temporary fix. The changes also handle kUnimplemented errors in Spanner integration tests, making them more robust. Overall, the changes look good. I have one minor suggestion to improve the maintainability of how one of the examples is disabled.

[gemini-code-assist]

For better maintainability, consider wrapping this code in an if (examples::UsingEmulator()) block instead of commenting it out. This makes the temporary nature of the change clearer and avoids having commented-out code, which can be confusing.

  // TODO(#15854): Enable this test when the issue is resolved.
  if (examples::UsingEmulator()) {
    std::cout << "\nRunning NativeSetBucketPublicIam() example" << std::endl;
    NativeSetBucketPublicIam(client, {bucket_name});
  }

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (46f7e8b) to head (a4fdfd6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15855   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files        2458     2458           
  Lines      227585   227590    +5     
=======================================
+ Hits       211531   211542   +11     
+ Misses      16054    16048    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.