Skip to content

fix: Empty last chunk case in resumable upload that is not a stream #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
john0312 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

fix: Empty last chunk case in resumable upload that is not a stream #1802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31e1967
fix: Empty last chunk case in resumable upload that is not a stream
john0312 May 16, 2022
1f7f160
Merge branch 'main' into fix-empty-last-chunk
chalmerlowe Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions googleapiclient/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,10 +1062,14 @@ def next_chunk(self, http=None, num_retries=0):
"Content-Length": str(chunk_end - self.resumable_progress + 1),
}

# An empty file results in chunk_end = -1 and size = 0
# sending "bytes 0--1/0" results in an invalid request
# Only add header "Content-Range" if chunk_end != -1
if chunk_end - self.resumable_progress + 1 == 0 and chunk_end != -1:
Copy link
Contributor

@vchudnov-g vchudnov-g Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if only fires if chunk_end != -1. But in that case, the if below also fires, overwriting this particular header. So this block as written has no effect on the end result.

# This is the last chunk, it's empty but the file is not empty.
# Send a Content-Range that ends this file.
headers["Content-Range"] = "bytes */%s" % (size,)
if chunk_end != -1:
# An empty file results in chunk_end = -1 and size = 0
# sending "bytes 0--1/0" results in an invalid request
# Only add header "Content-Range" if chunk_end != -1
headers["Content-Range"] = "bytes %d-%d/%s" % (
self.resumable_progress,
chunk_end,
Expand Down
Loading