Cache the protocol version #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ia0
added
crate:cli
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a DynDevice wrapper to cache the device's protocol version upon connection. This is a great improvement for efficiency, as it avoids repeated calls to get the version. The changes are applied consistently across the cli-tools and example crates, replacing dyn Connection with the new DynDevice type. The removal of the PlatformApiVersion action simplifies the API.
I have one main point of feedback regarding the removal of a workaround for USB/IP devices, which might be a potential regression. Please see the detailed comment.
ia0
force-pushed
the
api-version
branch
2 times, most recently
from
6255f5b to
70a91ea
Compare
ia0-review
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to call the appropriate service based on the device version.