Skip to content

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Dec 19, 2025

No description provided.

@ia0 ia0 added crate:cli Modifies the users CLI for:usability Improves users (and maintainers) life labels Dec 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CLI to use the same nightly toolchain as defined in the repository's rust-toolchain.toml. It introduces a helper function to check for command existence and a script to synchronize the toolchain version. My review focuses on the robustness of the new script and the public helper function. I've identified a potential bug in the shell script that could cause it to fail with certain toolchain names, and a correctness issue in the new exists function that should be addressed by documenting its limitations.

@ia0
Copy link
Member Author

ia0 commented Dec 19, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to standardize the Rust nightly toolchain used by the CLI, aligning it with the version specified in rust-toolchain.toml. This is achieved by introducing a nightly_toolchain helper that modifies cargo commands when rustup is available. A new sync.sh script is added to keep the toolchain version in the source code synchronized with rust-toolchain.toml. While the overall approach is sound, the sync.sh script contains bugs that prevent it from working correctly. My review provides a critical fix to make the script robust and functional.

@ia0 ia0 merged commit 2369b2d into google:main Dec 19, 2025
27 checks passed
@ia0 ia0 deleted the nightly branch December 19, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate:cli Modifies the users CLI for:usability Improves users (and maintainers) life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants