Simplify RendererClient
#1422
Open
Simplify RendererClient
#1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a preparation before fixing google#1421, this commit aims to simplify RendererClient without changing its behavior. Major updates are: * Optional member fields to override default behaviors for testing purposes now have suffix "_for_testing" and are explicitly injected via CreateForTesting() factory method. * Removed unnecessary nullptr checks. * Removed unused SetSendCommandInterface(). Main motivation is to make it possible to inject a custom service name for testing purpose in the next change for google#1421, as the current design uses hard-coded service name even in the test code. Other than above, there should be no functional changes in the production code.
yukawa
force-pushed
the
issue_1421_prep
branch
from
f416933 to
d78b548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a preparation before fixing #1421, this commit aims to simplify
RendererClientwithout changing its behavior.Major updates are:
CreateForTesting()factory method.SetSendCommandInterface().Main motivation is to make it possible to inject a custom service name for testing purpose in the next change for #1421, as the current design uses hard-coded service name even in the test code.
Other than above, there should be no functional changes in the production code.
Issue IDs
//renderer:renderer_server_testfails whenmozc_rendereris already running in Windows #1421Steps to test new behaviors (if any)