-
Notifications
You must be signed in to change notification settings - Fork 18.7k
unicode: remove variation selectors from IsGraphic and IsPrint #76875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
unicode: remove variation selectors from IsGraphic and IsPrint #76875
Conversation
|
This PR (HEAD: 4a18f52) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/730980. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/730980. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/730980. |
|
Message from Saransh Saini: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/730980. |
|
Message from Rob Pike: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/730980. |
|
Message from Saransh Saini: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/730980. |
IsGraphic and IsPrint return true for Variation Selectors, which are invisible.
This just adds a check to not include those, and a test to verify.
Fixes #73673