Package API: Support in-memory taskfile nodes with task.Executor. #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trulede
changed the title
trulede
force-pushed
the
PR/node_bytes
branch
2 times, most recently
from
7d77c36 to
87cf5bc
Compare
trulede
commented
Nov 30, 2025
| } | ||
|
|
||
| func (node *ByteNode) Remote() bool { | ||
| return true |
Contributor
Author
There was a problem hiding this comment.
Here, I'm not certain if this should actually be false. It may not matter either way.
Member
|
I'll delegate this review to @pd93. Also, this needs a rebase. |
trulede
force-pushed
the
PR/node_bytes
branch
from
87cf5bc to
ca7d0f5
Compare
Contributor
Author
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Package API, make it possible to create taskfile objects from []byte/memory objects (i.e. raw unparsed YAML data).
This use case only exists when using the Package API. Its behaviour/operation is similar to
NodeStdin.