-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Filter bot traffic from Sentry spans using tracesSampler #16213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jaffrepaul
wants to merge
7
commits into
master
Choose a base branch
from
docs-span-throughput-ogwo0y
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+114
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a tracesSampler function to drop spans from HeadlessChrome, bots, crawlers, and other automated traffic. This prevents bot-induced span throughput anomalies while maintaining 100% sampling for real users. Fixes DOCS-A4C Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Hoist bot patterns to module scope to avoid recreation on each trace - Use single regex test instead of array iteration with includes() - Add monitoring tool patterns: lighthouse, pagespeed, gtmetrix, pingdom, uptimerobot Co-Authored-By: Claude <[email protected]> Co-authored-by: Cursor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Add allowlist for AI agents (ClaudeBot, GPTBot, Cursor, Codex, Copilot, etc.) to ensure we have tracing data for agentic tools consuming our markdown docs. These are checked before the bot filter so they won't be dropped by the generic 'bot' pattern. Co-Authored-By: Claude <[email protected]> Co-authored-by: Cursor <[email protected]>
The generic 'bot' pattern incorrectly matched Cubot phone user agents (e.g., "CUBOT GT99"), dropping traces for legitimate mobile users. Replace with explicit bot names: googlebot, bingbot, slackbot, etc. Co-Authored-By: Claude <[email protected]> Co-authored-by: Cursor <[email protected]>
4fc2e5c to
b6c90b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tracesSampler with bot filtering and 30% user sampling
Filter out crawlers/bots while allowlisting AI agents at 100% for
docs consumption visibility. Real users sampled at 30% for high-traffic site.
Fixes DOCS-A4C
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES