Wordpress galleries: use hash value that stays identical over different invocations #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the gallery ID uses
Context.id, which was initialized withhash()from some string. Since the value ofhash()can change between different invocations of Python, this is not very helpful... I've replaced it with a truncated SHA256 converted to int. It's a bit inefficient, but definitely stable.I've only used this for one old travel blog that hasn't been updated since 2014, so I never noticed that the gallery IDs change...
(There's another
hash()use in the LaTeX parser, but that ID is never used as far as I can see, so I didn't touch it for now.)