Skip to content

Conversation

@psschwei
Copy link
Member

@psschwei psschwei commented Jan 30, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue:

Allows all model IDs to have a consistent format optimized for readability (name for each backend on its own line):

Example:

MISTRALAI_MISTRAL_0_3_7B = ModelIdentifier(
    hf_model_name="mistralai/Mistral-7B-Instruct-v0.3",
    ollama_name="mistral:7b",
)

Personally, I think this helps make it easier to see which IDs work with which backend(s), but will leave it up to the group to decide if its worth merging.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Jan 30, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@planetf1
Copy link
Contributor

likely conflict with #357, but easy resolution

Did you verify how ruff will format? sometimes there are heuristics relating to how many parameters for single vs multi-line - can be updated in rules but I'd go with defaults.

@psschwei
Copy link
Member Author

Did you verify how ruff will format?

from my searching, seems to do this requires turning off the formatter for this file as stated above. As the file is mostly constants I think that's ok (but it's a tradeoff and others may have different opinions on if its worth it)

@psschwei
Copy link
Member Author

Per @ajbozarth suggestion, instead of disabling the linter, adding comments to each line to hack linebreaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants