feat: include TP config information in cache key #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the cache key generation for both SwaggerClientProvider and OpenApiClientProvider to include TypeProviderConfig information, ensuring proper cache differentiation between different Target Framework Moniker (TFM) builds.
- Adds cfg.RuntimeAssembly, cfg.ResolutionFolder, and cfg.SystemRuntimeAssemblyVersion to cache keys
- Follows the same approach used by FSharp.Data for TFM differentiation
- Reformats cache key tuples for better readability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SwaggerProvider.DesignTime/Provider.SwaggerClient.fs | Updates cache key to include TP config properties for TFM differentiation in SwaggerClientProvider |
| src/SwaggerProvider.DesignTime/Provider.OpenApiClient.fs | Updates cache key to include TP config properties for TFM differentiation in OpenApiClientProvider |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #260