Make Python optional & Modernise Github Actions #484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets precedent for including additional language bootstraps.
- It now also tests the --early-preseed and --repo options implicitly. - Upgraded all actions to v4. - Test Python bootstrap separately.
stikonas
requested changes
Dec 17, 2024
Collaborator
stikonas
left a comment
stikonas
left a comment
There was a problem hiding this comment.
Do we need to enforce all extras when calculate checksum mode is activated
| parser.add_argument("--internal-ci", help="INTERNAL for github CI") | ||
| parser.add_argument("-s", "--swap", help="Swap space to allocate in Linux", | ||
| default=0) | ||
| parser.add_argument("-x", "--extras", help="Comma-separated list of extra bootstraps to run (python)", |
Collaborator
There was a problem hiding this comment.
I think choices = ['python'] with nargs="+" would work better. You would not need to do the checks bellow then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two are fairly interlinked so I just included them together.
CI Must run to completion