Skip to content

fix(a380x/sfcc): slats/flaps cruise baulk display fixes #10425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FozzieHi wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix(a380x/sfcc): slats/flaps cruise baulk display fixes #10425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
998100f
Fix slats flaps cruise baulk activating when overspeeding CONF 1
FozzieHi Dec 2, 2025
51ed067
Display slats flaps cruise baulk as CONF 0 in Lower PFD
FozzieHi Dec 2, 2025
859617f
Set to 1 if slatsFlapCruiseBaulk is true
FozzieHi Dec 2, 2025
a35f665
refactor(a380x/pfd): Use MappedSubjects in Flap/slat display
lukecologne Dec 3, 2025
d0dbd78
Update bit 26 condition
FozzieHi Dec 3, 2025
61e7633
Check bit 26 in test
FozzieHi Dec 3, 2025
8ce8274
Add changelog
FozzieHi Dec 3, 2025
4dc6c4f
Update bit 26 condition
FozzieHi Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
1. [A380X/FMS] Add - sign to LS slope value - @Jonny23787 (Jonathan)
1. [A380X/MFD] Implement Position Monitor page - @BravoMike99 (bruno_pt99)
1. [A380X/MFD] Only show "RETURN" button on PERF & POS NAVAIDS if acessed via INIT page keys - @BravoMike99 (bruno_pt99)
1. [A380X/SFCC] Improved slats/flaps cruise baulk trigger and display - @FozzieHi (fozzie), @lukecologne (luke)

## 0.14.0

Expand Down
286 changes: 166 additions & 120 deletions fbw-a380x/src/systems/instruments/src/PFD/LowerArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,6 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {
ClockEvents & Arinc429Values & PFDSimvars & FwcDataEvents & SfccEvents
>();

private targetClass = Subject.create('');

private targetText = Subject.create('');

private readonly targetVisible = Subject.create('hidden');

private readonly slatExtensionVisible = Subject.create('hidden');

private readonly flapExtensionVisible = Subject.create('hidden');

// FIXME don't use commanded position from just one spoiler + figure out whether it's averaged, or max-ed
private readonly spoilersCommandedPosition = ConsumerSubject.create(
this.sub.on('spoilersCommanded').whenChanged(),
Expand All @@ -84,16 +74,6 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {

private readonly speedBrakesPosDisagree = Subject.create(false);

private slatIndexClass = Subject.create('');

private flapIndexClass = Subject.create('');

private targetBoxVisible = Subject.create('hidden');

private slatsTargetPos = Subject.create(0);

private flapsTargetPos = Subject.create(0);

private slatsPath = Subject.create('');

private slatsLinePath = Subject.create('');
Expand All @@ -114,22 +94,6 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {

private readonly slatsDataValid = Subject.create(true);

private configClean: boolean = false;

private config1: boolean = false;

private config2: boolean = false;

private config3: boolean = false;

private configFull: boolean = false;

private flaps1AutoRetract: boolean = false;

private slatsOut: boolean = false;

private flapsOut: boolean = false;

private readonly slatFlapStatusWord = Arinc429LocalVarConsumerSubject.create(
this.sub.on('slat_flap_system_status_word_1'),
Arinc429Register.empty().rawWord,
Expand All @@ -145,17 +109,174 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {
Arinc429Register.empty().rawWord,
);

private readonly configClean = MappedSubject.create(([word]) => word.bitValue(17), this.slatFlapStatusWord);

private readonly config1 = MappedSubject.create(([word]) => word.bitValue(18), this.slatFlapStatusWord);

private readonly config2 = MappedSubject.create(([word]) => word.bitValue(19), this.slatFlapStatusWord);

private readonly config3 = MappedSubject.create(([word]) => word.bitValue(20), this.slatFlapStatusWord);

private readonly configFull = MappedSubject.create(([word]) => word.bitValue(21), this.slatFlapStatusWord);

private readonly flaps1AutoRetract = MappedSubject.create(([word]) => word.bitValue(26), this.slatFlapStatusWord);

private readonly slatsOut = MappedSubject.create(([word]) => word.valueOr(0) > 6.1, this.slatPositionWord);

private readonly flapsOut = MappedSubject.create(([word]) => word.valueOr(0) > 5.0, this.flapPositionWord);

private targetText = MappedSubject.create(
([configClean, config1, config2, config3, configFull, flaps1AutoRetract]) => {
if (configClean) {
return '0';
} else if (config1 && flaps1AutoRetract) {
return '1';
} else if (config1) {
return '1+F';
} else if (config2) {
return '2';
} else if (config3) {
return '3';
} else if (configFull) {
return 'FULL';
} else {
return '';
}
},
this.configClean,
this.config1,
this.config2,
this.config3,
this.configFull,
this.flaps1AutoRetract,
);

private readonly slatsTargetPos = MappedSubject.create(
([configClean, config1, config2, config3, configFull, slatPositionWord]) => {
const slats = slatPositionWord.valueOr(0);
if (configClean && slats > 6.1) {
return 0;
} else if ((config1 || config2) && (slats < 276 || slats > 296)) {
return 1;
} else if ((config3 || configFull) && (slats < 317 || slats > 337)) {
return 2;
} else {
return null;
}
},
this.configClean,
this.config1,
this.config2,
this.config3,
this.configFull,
this.slatPositionWord,
);

private readonly flapsTargetPos = MappedSubject.create(
([configClean, config1, config2, config3, configFull, flaps1AutoRetract, flapPositionWord, flapsOut]) => {
const flaps = flapPositionWord.valueOr(0);

if ((configClean || (config1 && flaps1AutoRetract)) && flapsOut) {
return 0;
} else if (config1 && !flaps1AutoRetract && (flaps < 210 || flaps > 220)) {
return 1;
} else if (config2 && (flaps < 254 || flaps > 264)) {
return 2;
} else if (config3 && (flaps < 292 || flaps > 302)) {
return 3;
} else if (configFull && (flaps < 333 || flaps > 343)) {
return 4;
} else {
return null;
}
},
this.configClean,
this.config1,
this.config2,
this.config3,
this.configFull,
this.flaps1AutoRetract,
this.flapPositionWord,
this.flapsOut,
);

private readonly targetVisible = MappedSubject.create(
([slatsOut, flapsOut, configClean]) => (slatsOut || flapsOut || !configClean ? 'visible' : 'hidden'),
this.slatsOut,
this.flapsOut,
this.configClean,
);

private readonly slatExtensionVisible = MappedSubject.create(
([slatsOut, flapsOut, configClean, flapsDataValid]) =>
(slatsOut || flapsOut || !configClean) && flapsDataValid ? 'visible' : 'hidden',
this.slatsOut,
this.flapsOut,
this.configClean,
this.slatsDataValid,
);

private readonly flapExtensionVisible = MappedSubject.create(
([slatsOut, flapsOut, configClean, slatsDataValid]) =>
(slatsOut || flapsOut || !configClean) && slatsDataValid ? 'visible' : 'hidden',
this.slatsOut,
this.flapsOut,
this.configClean,
this.flapsDataValid,
);

private readonly inMotion = MappedSubject.create(
([flapsTargetPos, slatsTargetPos]) => flapsTargetPos !== null || slatsTargetPos !== null,
this.flapsTargetPos,
this.slatsTargetPos,
);

private readonly targetClass = MappedSubject.create(
([inMotion]) => (inMotion ? 'FontMedium Cyan MiddleAlign' : 'FontMedium Green MiddleAlign'),
this.inMotion,
);

private readonly targetBoxVisible = MappedSubject.create(
([inMotion]) => (inMotion ? 'visible' : 'hidden'),
this.inMotion,
);

private readonly slatIndexClass = MappedSubject.create(
([slatsFault, slatsOut, flapsOut, configClean]) => {
if (slatsFault) {
return 'NormalStroke Amber CornerRound';
} else if (slatsOut || flapsOut || !configClean) {
return 'NormalStroke Green CornerRound';
} else {
return 'NormalStroke White CornerRound';
}
},
this.slatsFault,
this.slatsOut,
this.flapsOut,
this.configClean,
);

private readonly flapIndexClass = MappedSubject.create(
([flapsFault, slatsOut, flapsOut, configClean]) => {
if (flapsFault) {
return 'NormalStroke Amber CornerRound';
} else if (slatsOut || flapsOut || !configClean) {
return 'NormalStroke Green CornerRound';
} else {
return 'NormalStroke White CornerRound';
}
},
this.flapsFault,
this.slatsOut,
this.flapsOut,
this.configClean,
);

onAfterRender(node: VNode): void {
super.onAfterRender(node);

this.slatFlapStatusWord.sub((s) => {
this.configClean = s.bitValue(17);
this.config1 = s.bitValue(18);
this.config2 = s.bitValue(19);
this.config3 = s.bitValue(20);
this.configFull = s.bitValue(21);
this.flaps1AutoRetract = s.bitValue(26);

this.flapReliefEngaged.set(s.bitValue(22));
this.alphaLockEngaged.set(s.bitValue(24));

Expand All @@ -164,29 +285,11 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {

this.slatsDataValid.set(s.bitValue(28));
this.flapsDataValid.set(s.bitValue(29));

if (this.configClean) {
this.targetText.set('0');
} else if (this.config1 && this.flaps1AutoRetract) {
this.targetText.set('1');
} else if (this.config1) {
this.targetText.set('1+F');
} else if (this.config2) {
this.targetText.set('2');
} else if (this.config3) {
this.targetText.set('3');
} else if (this.configFull) {
this.targetText.set('FULL');
} else {
this.targetText.set('');
}
}, true);

this.slatPositionWord.sub((s) => {
const slats = s.valueOr(0);

this.slatsOut = slats > 6.1;

// Slats and flaps should align with future implementation; do not change
const xFactor = -0.43;
const yFactor = 0.09;
Expand All @@ -210,23 +313,10 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {
const y = yFactor * value + 195.3;
this.slatsPath.set(`M ${x},${y} a 0.2 0.2 0 0 1 -1.3 -1.9 l 1.4 -0.7 z`);
this.slatsLinePath.set(`M 15.2 195.4 L ${x},${y}`);

if (this.configClean && slats > 6.1) {
this.slatsTargetPos.set(0);
} else if ((this.config1 || this.config2) && (slats < 276 || slats > 296)) {
this.slatsTargetPos.set(1);
} else if ((this.config3 || this.configFull) && (slats < 317 || slats > 337)) {
this.slatsTargetPos.set(2);
} else {
this.slatsTargetPos.set(null);
}
});
}, true);

this.flapPositionWord.sub((s) => {
const flaps = s.valueOr(0);
const flapDetctThrshld = 5.0;

this.flapsOut = flaps > flapDetctThrshld;

// Slats and flaps should align with future implementation; do not change
const xFactor = 0.87;
Expand Down Expand Up @@ -263,51 +353,7 @@ class SlatsFlapsDisplay extends DisplayComponent<{ bus: ArincEventBus }> {
const y = yFactor * value + 193.1;
this.flapsPath.set(`M${x},${y} v 2.6 h 3.9 z`);
this.flapsLinePath.set(`M 31.8 193.1 L ${x},${y}`);

if ((this.configClean || this.flaps1AutoRetract) && flaps > flapDetctThrshld) {
this.flapsTargetPos.set(0);
} else if (this.config1 && !this.flaps1AutoRetract && (flaps < 210 || flaps > 220)) {
this.flapsTargetPos.set(1);
} else if (this.config2 && (flaps < 254 || flaps > 264)) {
this.flapsTargetPos.set(2);
} else if (this.config3 && (flaps < 292 || flaps > 302)) {
this.flapsTargetPos.set(3);
} else if (this.configFull && (flaps < 333 || flaps > 343)) {
this.flapsTargetPos.set(4);
} else {
this.flapsTargetPos.set(null);
}
});

this.sub.on('realTime').handle((_t) => {
const inMotion = this.flapsTargetPos.get() !== null || this.slatsTargetPos.get() !== null;
this.targetVisible.set(this.slatsOut || this.flapsOut || !this.configClean ? 'visible' : 'hidden');
this.flapExtensionVisible.set(
(this.slatsOut || this.flapsOut || !this.configClean) && this.flapsDataValid.get() ? 'visible' : 'hidden',
);
this.slatExtensionVisible.set(
(this.slatsOut || this.flapsOut || !this.configClean) && this.flapsDataValid.get() ? 'visible' : 'hidden',
);

if (this.slatsFault.get()) {
this.slatIndexClass.set('NormalStroke Amber CornerRound');
} else if (this.slatsOut || this.flapsOut || !this.configClean) {
this.slatIndexClass.set('NormalStroke Green CornerRound');
} else {
this.slatIndexClass.set('NormalStroke White CornerRound');
}

if (this.flapsFault.get()) {
this.flapIndexClass.set('NormalStroke Amber CornerRound');
} else if (this.slatsOut || this.flapsOut || !this.configClean) {
this.flapIndexClass.set('NormalStroke Green CornerRound');
} else {
this.flapIndexClass.set('NormalStroke White CornerRound');
}

this.targetClass.set(inMotion ? 'FontMedium Cyan MiddleAlign' : 'FontMedium Green MiddleAlign');
this.targetBoxVisible.set(inMotion ? 'visible' : 'hidden');
});
}, true);
}

spoilersLogFn(x: number) {
Expand Down
Loading