feat(a380x): BTV, ROW, ROP improvements #10372

flogross89 · 2025-10-18T07:20:05Z

Summary of Changes

add INOP SYS: BTV, ARPT NAV, ROW/ROW, RWY OVERRUN PROT
add LIMITATIONS: LDG DIST AFFECTED, LDG PERF AFFECTED
add BTV/ROW/ROP failure states to FCDC
add BTV/ROP/ROW deactivation in Rust for failure states
add triple clicks for BTV disarming/deactivation
add ROW/ROP automatic runway detection in fbw-common
Fix: [A380X] BTV top message not hidden after landing and auto brake disengagement #10043: Hide BTV message when deactivating, delete BTV data

Note: The arming/disarming and reversion logic might not be 100% accurate yet, but it brings us closer to where we want to be.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

Regression tests:

Perform BTV landing with Navigraph linked and exit selected through OANS (normal landing)
Perform approach with Navigraph linked and runway selected through OANS (long flare, wait until "RWY TOO SHORT" triggers)
Perform BTV landing with Navigraph not linked (i.e. fallback), selected landing distance through OANS control panel (normal landing)
Perform BTV landing with Navigraph not linked (i.e. fallback), selected landing distance through OANS control panel (long flare, wait until "RWY TOO SHORT" triggers)

New features test:

Don't set any FMS destination airport or FMS landing runway. Approach arbitrary airport, perform low approach without landing. At the end of the runway, "RWY TOO SHORT" should be visible in the PFD and audible
Confirm that BTV RWY indication does not reset #9705 and [A380X] BTV top message not hidden after landing and auto brake disengagement #10043 are fixed
Set up aircraft for BTV landing selected through OANS; Fail BTV (either by pulling ARPT NAV reset knob or disabling one PRIM), BTV should downgrade to BRK HI and shouldn't activate on landing

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, find and click on the PR Build tab
Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

add LIMITATIONS: LDG DIST AFFECTED, LDG PERF AFFECTED add BTV/ROW/ROP failure states to FCDC

- triple click when deactivation on ground or disarming in flight below 700ft RA - BTV fault conditions to Rust - ROW/ROP fault conditions to Rust

- add LGCIU bus publisher - refactor BtvPublisher to account for the above

…rching

- set airport when landing RWY detected by ROPS

… communication to Rust BTV from one place (in systems-host) still doesn't work

# Conflicts: # fbw-a380x/src/systems/systems-host/PseudoPRIM/BrakeToVacateDistanceUpdater.ts # fbw-common/src/systems/instruments/src/OANC/Oanc.tsx # fbw-common/src/systems/instruments/src/OANC/OansBrakeToVacateSelection.ts # fbw-common/src/systems/oans/OansMapProjection.ts # fbw-common/src/systems/shared/src/publishers/OansBtv/FmsOansPublisher.ts

BravoMike99

Some minor comments, also, you forgot to take it out of draft I believe

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts

fbw-common/src/systems/shared/src/publishers/ArincBus/RaBusPublisher.ts

fbw-a380x/src/systems/systems-host/PseudoPRIM/BrakeToVacate.ts

fbw-a380x/src/wasm/fbw_a380/src/FlyByWireInterface.cpp

…I reversion when different runway is approached

tracernz

Just reviewing the ARINC bus publishers only.

fbw-common/src/systems/shared/src/publishers/ArincBus/RaBusPublisher.ts

fbw-common/src/systems/shared/src/publishers/ArincBus/LgciuBusPublisher.ts

fbw-common/src/systems/shared/src/publishers/OansBtv/BtvPublisher.ts

tracernz

Thanks for the fixes! I scanned over the rest and note a couple of small suggestions. Otherwise LGTM with the import that's failing the build fixed up.

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts

fbw-common/src/systems/oans/OansMapProjection.ts

BravoMike99

Some more minor things

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts

fbw-a380x/src/systems/systems-host/PseudoPRIM/BrakeToVacate.ts

BravoMike99

Some minor things

fbw-a380x/src/systems/systems-host/PseudoPRIM/BrakeToVacate.ts

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts

Jonny23787

Just for future consistency

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsAbnormalSensed.ts

# Conflicts: # fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts # fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsLimitations.ts

Jonny23787 · 2025-12-09T07:17:35Z

Quality Assurance Tester Report

Discord Username : jonny_23
Object of testing : #10372
Aircraft : A380X
Simulator : 2020
Tier of Testing : 1
Date : 09/12/2025

Testing Process:
All testing conducted without Navigraph

Tested BTV manual landing, BTV activated.
Performed a long flare with RWY in FMS, RWY TOO SHORT message appeared on PFD.
Performed a long flare without RWY or airport in FMS, RWY TOO SHORT message appeared on PFD.
BTV top message did not disappear after landing.
Setup BTV landing, pulled ARPT NAV reset switch, braking reverted to HI and triggered correctly upon landing.

Testing Results:
Not Passed

Negatives:

Runway length did not appear on the manual control / fallback page.
BTV message did not hide after landing with either full or downgraded BTV
After performing BTV landing an arbitrary distance was inserted in the BTV STOP DISTANCE field, I did not insert this value at any time.
After performing a long flare without RWY or airport in FMS, runway appeared as a top message, is this correct behaviour?

Conclusions:

Media:

flogross89 added 2 commits October 18, 2025 07:08

ARPT NAV INOP SYS

8f3e4d6

add INOP SYS: BTV, ARPT NAV, ROW/ROW, RWY OVERRUN PROT

2cf0aaf

add LIMITATIONS: LDG DIST AFFECTED, LDG PERF AFFECTED add BTV/ROW/ROP failure states to FCDC

flogross89 added QA A380 Only QA only for A380 required A380X Related to the A380X aircraft labels Oct 18, 2025

flogross89 added this to the v0.15.0 milestone Oct 18, 2025

flogross89 added 14 commits October 19, 2025 00:40

- unload BTV data when deactivated on ground (fixes two bugs)

5476e9a

- triple click when deactivation on ground or disarming in flight below 700ft RA - BTV fault conditions to Rust - ROW/ROP fault conditions to Rust

- add RA bus publisher

66acf7a

- add LGCIU bus publisher - refactor BtvPublisher to account for the above

implement ROPS runway detection

7c944b6

Merge branch 'master' into fix-oans-improv1025

c6e1ada

add question

109038d

refactor to shared code

842b024

invalidate nearby facility search location to prevent unnecessary sea…

c89b5fc

…rching

fixes; don't mark OANS as INOP if Navigraph not linked

048eef0

- only set local airport pos from one place

969cef2

- set airport when landing RWY detected by ROPS

TERR OFF -> ROPS OFF

a5e83f4

only use nav db reference point; doesnot work tho

8339560

refactor OANS/BTV: Remove navdata dependency from OANC module, handle…

7931465

… communication to Rust BTV from one place (in systems-host) still doesn't work

fix BTV

593e453

BravoMike99 reviewed Nov 7, 2025

View reviewed changes

flogross89 added 3 commits November 7, 2025 22:29

If BTV arming lost, revert to BRK HI

2917b5d

fix BTV triple click

7779f85

remove RadioAltimeterPublisher (different one used); add BTV to BRK H…

b85196d

…I reversion when different runway is approached

flogross89 marked this pull request as ready for review November 8, 2025 01:59

flogross89 requested a review from BravoMike99 November 8, 2025 01:59

remove unnecessary allocations; ROP/ROW only disabled by OANS reset pb

2e1d734

tracernz reviewed Nov 8, 2025

View reviewed changes

flogross89 added 3 commits November 9, 2025 01:19

move OansControlEventsPublisher

12b69e7

Merge branch 'master' into fix-oans-improv1025

8b24906

tracer's review comments

51590bc

fix some more imports

02890cb

flogross89 requested a review from tracernz November 9, 2025 00:09

tracernz approved these changes Nov 9, 2025

View reviewed changes

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts Outdated Show resolved Hide resolved

fbw-common/src/systems/oans/OansMapProjection.ts Outdated Show resolved Hide resolved

BravoMike99 requested changes Nov 9, 2025

View reviewed changes

flogross89 added 4 commits November 10, 2025 01:32

bruno's comments

e0c2388

tracer's comments

0cdacac

Merge branch 'master' into fix-oans-improv1025

9b3a607

Merge branch 'master' into fix-oans-improv1025

565c73e

flogross89 requested a review from BravoMike99 November 24, 2025 20:56

fix Rust test / disarming conditions

daf48be

BravoMike99 reviewed Nov 26, 2025

View reviewed changes

fbw-a380x/src/systems/systems-host/PseudoPRIM/BrakeToVacate.ts Show resolved Hide resolved

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts Outdated Show resolved Hide resolved

flogross89 added 2 commits November 27, 2025 01:58

smaller fixes

092aee8

Merge branch 'master' into fix-oans-improv1025

04ccfb0

flogross89 requested a review from BravoMike99 November 26, 2025 23:59

BravoMike99 approved these changes Nov 27, 2025

View reviewed changes

flogross89 mentioned this pull request Dec 1, 2025

feat(a380x/sd): Port & improve STATUS page #10417

Open

7 tasks

Jonny23787 reviewed Dec 5, 2025

View reviewed changes

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsAbnormalSensed.ts Outdated Show resolved Hide resolved

fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsAbnormalSensed.ts Outdated Show resolved Hide resolved

flogross89 added 2 commits December 6, 2025 19:02

use correct enum

dd2857c

Merge branch 'master' into fix-oans-improv1025

0c68be7

# Conflicts: # fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsCore.ts # fbw-a380x/src/systems/systems-host/CpiomC/FlightWarningSystem/FwsLimitations.ts

github-actions bot added the QA Failed label Dec 9, 2025

Uh oh!

feat(a380x): BTV, ROW, ROP improvements #10372

Are you sure you want to change the base?

feat(a380x): BTV, ROW, ROP improvements #10372

Uh oh!

Conversation

flogross89 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

Uh oh!

BravoMike99 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tracernz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tracernz left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BravoMike99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BravoMike99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jonny23787 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Jonny23787 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flogross89 commented Oct 18, 2025 •

edited

Loading

BravoMike99 left a comment •

edited

Loading

tracernz left a comment •

edited

Loading

Jonny23787 commented Dec 9, 2025 •

edited

Loading