Skip to content

Conversation

@evroon
Copy link
Contributor

@evroon evroon commented Sep 21, 2025

Summary of Changes

Fixes a broken link in Contributing.md that used to point to this, but since v10.0, it is broken. It seems like it's supposed to link to the website instead now.

I assumed an issue and changelog entry wouldnt be necessary.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BlueberryKing
Copy link
Member

Thanks for contributing!

The link is not broken for me. It leads to https://github.com/flybywiresim/aircraft/blob/master/fbw-a32nx/docs/resources.md , where we do list development resources.

However, some of the resources, such as the tools at the top, are outdated and should be removed from that page. I like adding a link to our website, but maybe that could be appended instead of replacing an existing link?

@BlueberryKing BlueberryKing changed the title Fix broken link to dev resources in Contributing.md fix(docs): fix broken link to dev resources in Contributing.md Sep 21, 2025
@evroon
Copy link
Contributor Author

evroon commented Sep 21, 2025

Hmm weird, for me the link goes to https://github.com/flybywiresim/aircraft/blob/fbw-a32nx/docs/resources.md. So github interprets the the path to the file as the branch name because there is no branch in the link. Maybe it should just be an absolute markdown link instead of relative?

I can add the website link instead of replacing it, sure, I'll do that tomorrow.

The slightly bigger changes you mention should perhaps take place after #10338 to avoid (more) merge conflicts.

@evroon
Copy link
Contributor Author

evroon commented Sep 21, 2025

Ahh I see now, if you click the link here https://github.com/flybywiresim/aircraft?tab=contributing-ov-file, the link is broken. But from https://github.com/flybywiresim/aircraft/blob/master/.github/Contributing.md, it works. So I guess best way to fix that is to make the link absolute?

@github-project-automation github-project-automation bot moved this from 🟡 Code Review: Ready for Review to 🟣 QA Review: Ready to Test in Quality Assurance Oct 8, 2025
@FoxtrotSierra6829 FoxtrotSierra6829 enabled auto-merge (squash) October 10, 2025 22:21
@FoxtrotSierra6829 FoxtrotSierra6829 merged commit a78b711 into flybywiresim:master Oct 10, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🟣 QA Review: Ready to Test to ✔️ Done in Quality Assurance Oct 10, 2025
@evroon evroon deleted the fix-link-to-dev-resources branch October 11, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✔️ Done

Development

Successfully merging this pull request may close these issues.

3 participants