distinguish non critical_sim_error #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvush
reviewed
Jan 5, 2026
| err = ?relay_result.unwrap_err(), | ||
| "Error block simulation fail, cancelling" | ||
| ); | ||
| let error_text = relay_result.as_ref().unwrap_err().to_string(); |
Contributor
There was a problem hiding this comment.
Can you please explain why are we adding this code here. We already had some code that handles non-critical sim error messages.
Collaborator
Author
There was a problem hiding this comment.
Moved to map_relay_error_message.
It's still a SimError so I added a flag to tell if it's critical. It was that or add a new error code.
Notice we need to cancel even if it's no critical.
dvush
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR avoids generating ERRORs and triggering alarms on MEV Protect errors.
✅ I have completed the following steps:
make lintmake test