Ml mixed fs #4795
Open
Ml mixed fs #4795
+79
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@connorjward - please ignore if you're on leave now! The broken link in the docs is https://gtr.ukri.org which will presumably start working again at some point... The failing test error is incomprehensible to me! Any advice much appreciated and thanks for your help! |
connorjward
previously approved these changes
Jan 5, 2026
Author
|
[celebrate] Shipton, Jemma reacted to your message:
…________________________________
From: Connor Ward ***@***.***>
Sent: Monday, January 5, 2026 12:09:39 PM
To: firedrakeproject/firedrake ***@***.***>
Cc: Shipton, Jemma ***@***.***>; Author ***@***.***>
Subject: Re: [firedrakeproject/firedrake] Ml mixed fs (PR #4795)
CAUTION: This email originated from outside of the organisation. Do not click links or open attachments unless you recognise the sender and know the content is safe.
@connorjward approved this pull request.
This is fantastic thank you! I will hold off on merging this in case the failures are relevant but I think you're just hitting #4784<#4784> which I hope to temporarily resolve tomorrow in #4782<#4782>
—
Reply to this email directly, view it on GitHub<#4795 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABUOTSQMABKVPUBRS4VXYX34FJIAHAVCNFSM6AAAAACPWBYFSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMRWGYYDKMBWHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
dham
requested changes
Jan 6, 2026
Co-authored-by: David A. Ham <[email protected]>
connorjward
approved these changes
Jan 8, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I'll merge this later this morning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for PyTorch and Jax with mixed functions.
Fixes #4774.