Skip to content

fix: add HTTP server timeouts for local network test helper (G114) #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arianbeh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add HTTP server timeouts for local network test helper (G114) #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f7fc7
fix: add HTTP server timeouts for local network test helper (G114)
arianbeh Dec 10, 2025
e74c944
removed G114 from .golangci.yml
arianbeh Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ issues:
exclude:
- G104 # Errors unhandled
- G103 # Use of unsafe calls should be audited
- G114 # Use of net/http serve function without timeouts.
- G115 # Integer overflow conversion should be audited
- G204 # Subprocess launched with variable
- G301 # Expect directory permissions to be 0750 or less
Expand Down
10 changes: 9 additions & 1 deletion internal/network_test_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"net/http"
"os/exec"
"testing"
"time"

"github.com/miekg/dns"
"golang.org/x/sync/errgroup"
Expand Down Expand Up @@ -132,7 +133,14 @@ func (l localNetworkServices) Serve(ctx context.Context) error {
})
}

return http.ListenAndServe(l.ipAddr+":80", nil)
srv := &http.Server{
Addr: l.ipAddr + ":80",
Handler: nil,
ReadTimeout: 5 * time.Second,
WriteTimeout: 5 * time.Second,
IdleTimeout: 30 * time.Second,
}
return srv.ListenAndServe()
})

return errGroup.Wait()
Expand Down