-
-
Notifications
You must be signed in to change notification settings - Fork 81
feature/crafting #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feature/crafting #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sweattypalms
requested changes
Nov 26, 2025
Member
Sweattypalms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I've reviewed your PR. Please have a look at the comments.
Member
|
lgtm, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements crafting with the survival inventory crafting grid. This does not implement a crafting table as those UIs have not been implemented yet. However, functionality to get a recipe from a 3x3 crafting grid does exist (
ferrumc_core::crafting::get_recipes_from_3x3) so crafting tables should be fairly simple to implement once we get there.When the survival crafting grid is updated, the code will search through recipes to find ones that match the current grid. If one is found, it will update the output to reflect that.
To make this work I had to implement basic inventory syncing. My code just assumes that the client is telling the truth and updates the player's inventory in whatever way the client tells it to. While for now this is fine, when we implement other containers (or even just the player inventory better) we want to ensure that changes are valid. Additionally, the crafting grid just gets cleared when the player closes their inventory. Again, this should be changed in later implementations of the inventory.
This PR does NOT add recipe searching functions for any other crafting type (smelting, blasting, campfire cooking, smithing, etc). It only implements the player's survival crafting grid (with the aforementioned functionality to support 3x3 grids).
If this PR gets merged I'm going to open issues for the inventory syncing problem so if someone else wants to tackle it, they can.