-
Notifications
You must be signed in to change notification settings - Fork 37
Use mount namespace to simplify code #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All the interesting "CI Test" are skipped, can someone trigger then manually ? |
111b84f to
c7be462
Compare
c7be462 to
3cb0f0d
Compare
|
rebase done |
|
/test |
|
CI is triggered and running here https://github.com/fedora-iot/greenboot/actions/runs/17999478754 , some jobs failed because of the download site in secrets cannot be accessed. Will update the secrets and run again. (CI triggered by comment /test should update the status of current check jobs, it's a minor bug here, I will fix it soon.) |
|
Hi @champtar sorry to bother you, but could you please rebase this pull request and push again? Rebase can include:
|
With mount namespace we don't need to remount `/boot` read only before exit. Also do not try to parse /proc/self/mountinfo, just use '-w' test flag. If a command is called directly without systemd, reexec ourselves with `unshare -m`.
3cb0f0d to
c23039f
Compare
|
@yih-redhat no problem, rebased again |
|
/test |
With mount namespace we don't need to remount
/bootread only before exit.Also do not try to parse /proc/self/mountinfo, just use '-w' test flag.
If a command is called directly without systemd, reexec ourselves with
unshare -m.