[types] fix package.json types path, patch types #1379
Merged
+259
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
I realized I made a silly typo in #1351 ("dist" vs "lib" in the
package.json#typesfield) and this PR fixes it.As part of this I added TypeScript tests for
@stylexjs/babel-pluginand fixed an issue that were running into withv0.17.2since we do not useskipLipCheck: true. Theflow-api-translatortool was generating invalid TypeScript in@stylexjs/babel-plugin/lib/shared/types/index.d.tswhich resulted in an error:This appears to be a regression with the upgrade of
flow-api-translatorin #1336. My fix is to just copy theindex.d.tsfile with a small edit:Sorry for the typo. Thanks again!
Pre-flight checklist
Contribution Guidelines