Skip to content

Conversation

@henryqdineen
Copy link
Contributor

@henryqdineen henryqdineen commented Dec 4, 2025

What changed / motivation ?

I realized I made a silly typo in #1351 ("dist" vs "lib" in the package.json#types field) and this PR fixes it.

As part of this I added TypeScript tests for @stylexjs/babel-plugin and fixed an issue that were running into with v0.17.2 since we do not use skipLipCheck: true. The flow-api-translator tool was generating invalid TypeScript in @stylexjs/babel-plugin/lib/shared/types/index.d.ts which resulted in an error:

Type alias name cannot be 'number'.(2457)`

This appears to be a regression with the upgrade of flow-api-translator in #1336. My fix is to just copy the index.d.ts file with a small edit:

@@ -187,7 +187,6 @@
 export declare const number: <T extends NumberValue = NumberValue>(
   value: NestedWithNumbers,
 ) => Num<T>;
-export declare type number = typeof number;
 type ResolutionValue = string | 0;
 export declare class Resolution<T extends ResolutionValue>
   extends BaseCSSType

Sorry for the typo. Thanks again!

Pre-flight checklist

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2025
Copy link
Member

@mellyeliu mellyeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mellyeliu mellyeliu merged commit f5ad17e into facebook:main Dec 9, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants