Fix iOS font weight regression due to boolean coercion #54976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a regression introduced in version 0.83.1 regarding font weight handling on iOS.
The Issue: In a recent change to font handling logic (likely intended for cleanup), a logic error was introduced using the Elvis operator combined with a boolean comparison.
#54934
Changelog:
[IOS] [FIXED] - Fix regression where custom fonts with specific weights rendered as Black/ExtraBold due to incorrect boolean coercion
Test Plan:
I verified this fix using a reproduction app with a custom font (e.g., Pretendard) that has multiple weights.
Environment: React Native 0.83.1
Before Fix: The text rendered as UIFontWeightBlack (extremely thick) because fontWeight was coerced to 1.0.
After Fix: The text correctly renders with the intended weight ('Pretendard-SemiBold'/600).