Skip to content

Conversation

@ptptsw
Copy link

@ptptsw ptptsw commented Dec 24, 2025

Summary:

This PR fixes a regression introduced in version 0.83.1 regarding font weight handling on iOS.

The Issue: In a recent change to font handling logic (likely intended for cleanup), a logic error was introduced using the Elvis operator combined with a boolean comparison.
#54934

// 🐛 Buggy logic in 0.83.1
fontWeight = (fontWeight != 0.0) ?: RCTGetFontWeight(font);

Changelog:

[IOS] [FIXED] - Fix regression where custom fonts with specific weights rendered as Black/ExtraBold due to incorrect boolean coercion

Test Plan:

I verified this fix using a reproduction app with a custom font (e.g., Pretendard) that has multiple weights.

Environment: React Native 0.83.1

Before Fix: The text rendered as UIFontWeightBlack (extremely thick) because fontWeight was coerced to 1.0.

After Fix: The text correctly renders with the intended weight ('Pretendard-SemiBold'/600).

IMG_6045 IMG_6044

@meta-cla
Copy link

meta-cla bot commented Dec 24, 2025

Hi @ptptsw!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 24, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants