-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/output yaml values #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
daee521 to
8fe80f2
Compare
|
|
||
| # yaml uses a shorthand to identify "on" and "off" tags. | ||
| # for GitHub workflows, we do NOT want "on" replaced with "True". | ||
| for character in ["O", "o"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to do custom overrides to prevent certain changes.
| @@ -1,197 +1,189 @@ | |||
| name: Checks | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the extra whitespaces by default are gone. is it important to restore these?
| name: Docs | ||
| needs: [ Version-Check ] | ||
| needs: | ||
| - Version-Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lists are broken into vertical splits
| python-version: "3.10" | ||
| poetry-version: "2.3.0" | ||
| - name: Build Documentation | ||
| run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be updated in the template to be 1 line
| # 1. Version numbers (e.g., 2.3.0, 3.10) | ||
| # 2. OS/image names (e.g., ubuntu-24.04) | ||
| # 3. Numeric strings that look like octals or floats (e.g., 045, 1.2) | ||
| QUOTE_REGEX = re.compile(r"^(\d+\.\d+(\.\d+)?|[a-zA-Z]+-\d+\.\d+|0\d+)$") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to alter the regex expression to be more/less robust.
By default, it does '3.10' but had 2.3.0 and ubuntu-24.04 without quotes.
| QUOTE_REGEX = re.compile(r"^(\d+\.\d+(\.\d+)?|[a-zA-Z]+-\d+\.\d+|0\d+)$") | ||
|
|
||
|
|
||
| def str_presenter(dumper, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicer to put all this render_template stuff in one module...& use render_template outside of it instead.
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: